Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-click menu not appearing on Windows/Linux #2747

Closed
philrz opened this issue Apr 9, 2023 · 2 comments · Fixed by #2895
Closed

Right-click menu not appearing on Windows/Linux #2747

philrz opened this issue Apr 9, 2023 · 2 comments · Fixed by #2895
Assignees
Labels
bug Something isn't working community

Comments

@philrz
Copy link
Contributor

philrz commented Apr 9, 2023

Repro is with GA Zui v1.0.1.

A community user reported the following in a Slack message and provided the attached video. I've reproduced the same behavior on Windows and also confirmed that it does not seem to repro on macOS. 🤔 In their own words:

Right clicking on the domain name may result in the context menu not appearing. A work around is to select the ‘inspector’ or clicking the corner of the table.
This was was on a Windows machine : )

ice_video_20230409-215458.mp4
@philrz philrz added bug Something isn't working community labels Apr 9, 2023
@philrz philrz changed the title Right-click menu not appearing when clicking aggregation table on Windows Right-click menu not appearing on Windows/Linux Oct 5, 2023
@philrz
Copy link
Contributor Author

philrz commented Oct 5, 2023

Another community user (running Zui Insiders on Windows 10) reported on a Slack thread that they bumped into what looks like another instance this issue. In their own words:

is this expected? my right click only works in table view if I right click on white space. If there is a value underneath the menu just blinks
This is win 10
zui_insiders_right_click

I first tried to reproduce the problem with Zui Insiders 1.3.1-4 on macOS using attached data input.csv and found it would not repro. I then tried on Windows 10 and found it did repro. Finally, I tried on Linux and found it did repro there, as shown in the attached video. Notice how sometimes after I right-click we can briefly see the ghostly outline of the menu.

Repro.mp4

The "it repros on Windows but not on macOS" symptom rang a bell and I found this existing issue. Since this is the second community user to independently bump into this, I'm boosting the priority in hopes it can be addressed before our next GA release.

@philrz philrz linked a pull request Jul 2, 2024 that will close this issue
8 tasks
@philrz
Copy link
Contributor Author

philrz commented Jul 2, 2024

Verified in Zui commit 9f091b6.

@jameskerr recently picked up this issue with intent to fix it, only to find that he could no longer reproduce it on Windows. Since it also repro'ed on Linux in the past, I looked into it further there and via binary search have confirmed that it started working at commit 9f091b6, which is associated with the changes in #2895. The attached video confirms that right-clicks on the values now bring up the menu as well, not just when clicking on white space. The "rings" effect appears with each right-click.

Verify.mp4

Thanks @jameskerr!

@philrz philrz closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants