Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor env variables usage #8705

Open
SanjoDeundiak opened this issue Dec 16, 2024 · 2 comments
Open

Refactor env variables usage #8705

SanjoDeundiak opened this issue Dec 16, 2024 · 2 comments

Comments

@SanjoDeundiak
Copy link
Member

SanjoDeundiak commented Dec 16, 2024

Currently, there is a standard way to obtain an env variable implemented here. There are 3 different ways to call that API depending on desired behaviour. The goal is to review where that API is used and unify its usage when an invalid env variable value is present. The correct behaviour is following:

  1. Print an ERROR level warning to the log and return the default value, if we can't propagate the error all the way to the user
  2. Return an error if we can propagate it all the way to the user
@ilyaaay
Copy link
Contributor

ilyaaay commented Dec 17, 2024

Hi. I want to take this issue

@SanjoDeundiak
Copy link
Member Author

@ilyaaay all yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants