Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metabase.grapqhl #332

Closed
christoph-maurer opened this issue Oct 16, 2024 · 5 comments
Closed

Update metabase.grapqhl #332

christoph-maurer opened this issue Oct 16, 2024 · 5 comments
Assignees
Labels
ISE Fraunhofer Institute for Solar Energy Systems ISE

Comments

@christoph-maurer
Copy link
Member

christoph-maurer commented Oct 16, 2024

Before creating the release #333, metabase.graphql should be updated from type-defs.graphqls .

@simon-wacker Is there already a description how to do it?

@christoph-maurer christoph-maurer added the ISE Fraunhofer Institute for Solar Energy Systems ISE label Oct 16, 2024
@christoph-maurer christoph-maurer self-assigned this Oct 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in EQWIN-P Oct 16, 2024
@github-actions github-actions bot added the triage Review issue to make sure it is relevant, actionable, and has all the necessary information label Oct 16, 2024
@christoph-maurer christoph-maurer removed the triage Review issue to make sure it is relevant, actionable, and has all the necessary information label Oct 16, 2024
@christoph-maurer christoph-maurer mentioned this issue Oct 16, 2024
2 tasks
@simon-wacker
Copy link
Contributor

simon-wacker commented Oct 21, 2024

type-defs.graphqls is updated by running make schema within the frontend container. metabase.graphql is updated by just copying type-defs.graphqls with cp in a shell or in your WYSIWYG file browser. I don't know if there needs to be a description for that. It seems kind of obvious/redundant to me. Because we need to copy a file from one project to another and people clone there projects wherever they want to, there cannot be a simple shell command that works for everybody.

@christoph-maurer
Copy link
Member Author

Thank you for the explanation @simon-wacker !

When I run

make shellb
make schema

in repo metabase, I get the error

me@682e099cfd12:~/app$ make schema
gq http://backend:8080/graphql/ --introspect > schema.graphql
/bin/sh: 1: gq: not found
make: *** [Makefile:151: schema] Error 127

@simon-wacker
Copy link
Contributor

Ja, das target heisst update-schema.

@christoph-maurer
Copy link
Member Author

When I run

make shellf
make update-schema

type-defs.graphql is updated. I can easily copy it from the repo metabase to api/apis/metabase.graphql.

@christoph-maurer
Copy link
Member Author

metabase.graphql was updated with cded5e6

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in EQWIN-P Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISE Fraunhofer Institute for Solar Energy Systems ISE
Projects
Status: Done
Development

No branches or pull requests

2 participants