Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GraphQL field id of Nodes should also encode the locale #26

Open
simon-wacker opened this issue Jan 5, 2022 · 0 comments
Open

The GraphQL field id of Nodes should also encode the locale #26

simon-wacker opened this issue Jan 5, 2022 · 0 comments
Labels
backend bug Something isn't working ISE Fraunhofer Institute for Solar Energy Systems ISE

Comments

@simon-wacker
Copy link
Contributor

For the reasons see https://github.com/building-envelope-data/api/blob/f75edaac57e325092effceca10177ae11d2c3164/apis/database.graphql#L1-L10 and https://github.com/building-envelope-data/api/blob/f75edaac57e325092effceca10177ae11d2c3164/apis/database.graphql#L417-L440 Currently, it encodes only the UUID (together with the table name to be unique in the database), see

descriptor
.ImplementsNode()
.IdField(t => t.Id)
.ResolveNode((context, id) =>
context
.DataLoader<TEntityByIdDataLoader>()
.LoadAsync(id, context.RequestAborted)! // Notice the null-forgiving operator `!`. It's bad that we need to use it here.
);
, and thus violates field stability. The same is true for the metabase project.

@simon-wacker simon-wacker added bug Something isn't working backend labels Jan 5, 2022
@christoph-maurer christoph-maurer moved this to 📋 Backlog in EQWIN-P Jan 17, 2023
@simon-wacker simon-wacker added the ISE Fraunhofer Institute for Solar Energy Systems ISE label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working ISE Fraunhofer Institute for Solar Energy Systems ISE
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant