We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonConverter
IData
Our JSON converter implementation https://github.com/ise621/metabase/blob/110b2e0fec32642476ea39bcab6f60182a87dc8a/backend/src/GraphQl/Databases/DatabaseResolvers.cs#L250 is not generic, inspired by https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-converters-how-to?pivots=dotnet-5-0#support-polymorphic-deserialization and https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-converters-how-to?pivots=dotnet-5-0#an-alternative-way-to-do-polymorphic-deserialization and seems quite brittle to me. It woud be great if some C# GraphQL framework supported polymorphic types. There is a pending pull request for the .NET GraphQL Client with such a converter.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Our JSON converter implementation https://github.com/ise621/metabase/blob/110b2e0fec32642476ea39bcab6f60182a87dc8a/backend/src/GraphQl/Databases/DatabaseResolvers.cs#L250 is not generic, inspired by https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-converters-how-to?pivots=dotnet-5-0#support-polymorphic-deserialization and https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-converters-how-to?pivots=dotnet-5-0#an-alternative-way-to-do-polymorphic-deserialization and seems quite brittle to me. It woud be great if some C# GraphQL framework supported polymorphic types. There is a pending pull request for the .NET GraphQL Client with such a converter.
The text was updated successfully, but these errors were encountered: