Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust selection filter to allow alpha-only barcodes #8

Open
mhucka opened this issue Sep 1, 2023 · 0 comments
Open

Adjust selection filter to allow alpha-only barcodes #8

mhucka opened this issue Sep 1, 2023 · 0 comments
Labels
Bug 🐛 Something isn't working

Comments

@mhucka
Copy link
Contributor

mhucka commented Sep 1, 2023

Boffo as of version 1.6.0 filters the user's spreadsheet selection in the command for looking up barcodes. It filters out anything that doesn't have at least one digit. The only purpose of this particular filter is that I wanted to guard against the user selecting a whole column with a title. If they have a spreadsheet like

Our Barcodes
────────
0930950
0930951
0930952
...

etc., and they select the whole column instead of selecting just the cells containing barcodes, I wanted to filter out the text "Our Barcodes" (or whatever they might have written in the header row) because in the output, Boffo creates a new sheet where the first column has a title (and the title is "Barcodes").

In a conversation with Kyle Banerjee on the code4lib Slack on 2023-09-01, I learned that some other sites do have barcodes that have no digits in them. This would be a problem for Boffo, which would ignore those barcodes completely.

I'm not sure what the solution is going to be. Maybe there needs to be a user preference setting that allows them to say "allow anything" or something like that.

@mhucka mhucka added the Bug 🐛 Something isn't working label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant