Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database layer refactor #357

Open
jsstevenson opened this issue Jun 12, 2024 · 0 comments
Open

Database layer refactor #357

jsstevenson opened this issue Jun 12, 2024 · 0 comments
Labels
priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@jsstevenson
Copy link
Member

A few varied but related issues to wade through

  • use singleton constructor for graph
  • make metakb.database.Graph injectable in places like the QueryHandler
  • feasibility of adhering to yield/close pattern for all cases where graph is used
  • separate the graph access class and more specific data loading methods (i.e. those used by transformers)
  • think about where we want transactional queries vs atomic queries

Generally, we want to focus on clean access to the graph, and to be very careful about any case where resources are manually managed and not automatically deconstructed. It's a little sloppy but improved in #356, but we can make it cleaner and more consistent with a refactor

@jsstevenson jsstevenson added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Development

No branches or pull requests

1 participant