Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support publishing to Business Accelerator Hub (api.sap.com) #61

Open
Fannon opened this issue Sep 26, 2024 · 3 comments
Open

Feat: Support publishing to Business Accelerator Hub (api.sap.com) #61

Fannon opened this issue Sep 26, 2024 · 3 comments

Comments

@Fannon
Copy link
Contributor

Fannon commented Sep 26, 2024

For Business Accelerator Hub (BAH) publishing, we need to split the ORD Packages from one package (current behavior) into one package per ORD resource type. Most notably this means that we need a dedicated package for assigning APIs and another one for the events.

@swennemers
Copy link
Contributor

It should be there, also as default. But let's do a test run with our ORA sample apps once moved to the plugin.

@zongqichen zongqichen self-assigned this Oct 16, 2024
@swennemers
Copy link
Contributor

well... the code looks differently

@zongqichen zongqichen removed their assignment Nov 8, 2024
@Fannon
Copy link
Contributor Author

Fannon commented Dec 20, 2024

@aramovic79 The rules which are most important are here: https://pages.github.tools.sap/CentralEngineering/open-resource-discovery-specification/spec-extensions/policy-levels/sap-core-v1#package

If you validate with sap:core:v1 some problems should already pointed out. I hope it's mostly about splitting up packages up correctly, according to the constraints.

Example: You have one package, containing APIs, Events and Consumption Bundles.

Now you need to split it up into 3 Packages, containing only the same kind.
If you have mixed visibility, you again need to split up. So it could be 6 packages in the end.

E.g. MyPackage -> MyPackageAPIs, MyPackageEvents, MyPackageConsumptionBundles

Now with visibility: MyPackageAPIsInternal, MyPackageEventsInternal, MyPackageConsumptionBundlesInternal.

I would just append "Internal" and treat "public" as the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants