Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple domain and XML parsing concerns #4

Open
agseco opened this issue Dec 24, 2014 · 3 comments
Open

Decouple domain and XML parsing concerns #4

agseco opened this issue Dec 24, 2014 · 3 comments

Comments

@agseco
Copy link

agseco commented Dec 24, 2014

Currently, domain classes like PaymentMethod are tied to SimpleXML's annotations. I think this is not good and perhaps they should be decoupled from this concerns somehow...

What do you think?

@mfornos
Copy link
Contributor

mfornos commented Dec 29, 2014

👍 Should be decoupled, but first should be decoupled the XML provider, in fact SimpleXML uses StAX under the hood. I think that is not a big issue, since SimpleXML is a lightweight dependency and allows to plug your preferred StAX implementation.

@agseco
Copy link
Author

agseco commented Dec 29, 2014

👌 let's do that.

@mfornos
Copy link
Contributor

mfornos commented Oct 4, 2015

The model also has dependencies on SimpleXML annotations.

@mfornos mfornos modified the milestone: 0.1.0 Release Oct 4, 2015
@mfornos mfornos added the design label Oct 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants