Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make modals fixed height #410

Open
arpi09 opened this issue Oct 17, 2019 · 2 comments
Open

Make modals fixed height #410

arpi09 opened this issue Oct 17, 2019 · 2 comments
Assignees
@Alexander-Mjoberg @arpi09
Labels
enhancement New feature or request

Comments

@arpi09
Copy link
Contributor

arpi09 commented Oct 17, 2019

No description provided.

@arpi09 arpi09 added the enhancement New feature or request label Oct 17, 2019
@arpi09 arpi09 self-assigned this Oct 17, 2019
@Alexander-Mjoberg
Copy link
Contributor

We should fix the width too, some feedback is that the modals weren't using enough space on the screen

@Alexander-Mjoberg
Copy link
Contributor

There's a resizeModals branch that has most of this solved, we should just added dynamic height if possible on the companyHelp and then it should be solid. The company screen is weird because it can become superlong if many students have been scanned.

@Alexander-Mjoberg Alexander-Mjoberg self-assigned this Nov 8, 2019
@Alexander-Mjoberg Alexander-Mjoberg mentioned this issue Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alexander-Mjoberg Alexander-Mjoberg

@arpi09 arpi09

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alexander-Mjoberg @arpi09