Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_interesting_input is returning too early #12

Open
flxflndy opened this issue Feb 28, 2017 · 0 comments
Open

is_interesting_input is returning too early #12

flxflndy opened this issue Feb 28, 2017 · 0 comments

Comments

@flxflndy
Copy link

I'm not sure if the project is still alive, but I was reading the code saw a little improvement.
The function is_interesting_input in NaFlCore.py is returning directly after the first difference
I think it would be better to save the return value and return after the loop has finish.
Otherwise the history_bitmap is not updated correctly and more testcase must be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant