Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Activity Completion Behavior #85

Open
eduardokraus opened this issue Jun 21, 2024 · 2 comments
Open

Incorrect Activity Completion Behavior #85

eduardokraus opened this issue Jun 21, 2024 · 2 comments

Comments

@eduardokraus
Copy link

While reviewing the code of mod_subcourse, I noticed that the string $string['completioncourse_help'] = 'If enabled, the activity is considered complete when a student completes the referenced course.'; suggests that an activity is marked as complete when a student completes the referenced course.

However, during my testing, I observed that all activities are marked as completed for all students when any of the students completes the activity. This indicates incorrect behavior, as it should only register when the student themselves completes the activity, regardless of other courses.

@victorttro
Copy link

victorttro commented Jul 2, 2024

I am experiencing that using "Course Completion" as criteria is not pulling through, unless I reset completion for the subcourse activity.

@eduardokraus
Copy link
Author

I made improvements to my GIT to be able to fix issues on clients: https://github.com/EduardoKrausME/moodle-mod_subcourse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants