Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors when using the action #1

Open
aqabawe opened this issue Jul 23, 2020 · 3 comments
Open

No errors when using the action #1

aqabawe opened this issue Jul 23, 2020 · 3 comments

Comments

@aqabawe
Copy link

aqabawe commented Jul 23, 2020

Hello,

I have the following action defined in my repo:

name: CI/CD
on: [push, pull_request]
jobs:
  flake8-lint:
    runs-on: self-hosted
    name: Lint
    steps:
    - uses: actions/checkout@master
    - name: GitHub Action for Flake8
      uses: cclauss/GitHub-Action-for-Flake8@master
      with:
        args: flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

The output when this action runs is

#########################################
Starting CI/CD:cclaussGitHub-Action-for-Flake8
0
#########################################
Completed CI/CD:cclaussGitHub-Action-for-Flake8

The thing is when I run flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics locally in the repo, I get 3 warnings. How come there's a difference, am I doing something wrong? I get the same result when using ubuntu-latest instead of the self-hosted runner.

@cclauss
Copy link
Owner

cclauss commented Jul 23, 2020

@aqabawe
Copy link
Author

aqabawe commented Jul 23, 2020

Well that's the thing, we're hosting our own action runner in our K8s cluster and this solution is perfect because it's contained in a Docker so we'll be able to use the same runner for multiple repos.

But I'll check the other one out thanks!

@MaxGhenis
Copy link

If this doesn't work, could you please remove it from the GitHub Actions Marketplace? https://github.com/marketplace/actions/github-action-for-flake8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants