Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve customized loading of referenced files #15

Open
cebe opened this issue Nov 22, 2018 · 1 comment
Open

Improve customized loading of referenced files #15

cebe opened this issue Nov 22, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@cebe
Copy link
Owner

cebe commented Nov 22, 2018

Currently there is no way to extend the code when loading needs to be customized. Also content detection for JSON vs. YAML could be optimized.

@cebe cebe added the enhancement New feature or request label Nov 22, 2018
@cebe
Copy link
Owner Author

cebe commented Nov 22, 2018

$content = file_get_contents($uri);
// TODO lazy content detection, should probably be improved
if (strpos(ltrim($content), '{') === 0) {
return json_decode($content, true);
} else {
return Yaml::parse($content);
}

@cebe cebe added this to the 1.5.0 milestone Mar 10, 2020
@cebe cebe modified the milestones: 1.5.0, 1.6.0 Dec 14, 2020
@cebe cebe changed the title Improve loading of refrenced files Improve customized loading of referenced files Dec 31, 2020
@cebe cebe removed this from the 1.6.0 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant