Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double precision conformance issues exposed by https://github.com/miloyip/nativejson-benchmark #10

Open
chadaustin opened this issue Feb 16, 2016 · 2 comments

Comments

@chadaustin
Copy link
Owner

See https://rawgit.com/miloyip/nativejson-benchmark/master/sample/conformance.html#1.%20Parse%20Validation

@aggsol
Copy link

aggsol commented Jun 1, 2017

Is this still on your agenda?

@chadaustin
Copy link
Owner Author

Hi @aggsol -- the only conformance issues are around the precision of very large and very small doubles, and when I looked into this last it looked like the only precision issues were at the least-significant digits. That said, I do think this is worth improving. I haven't prioritized it because many JSON encoders have precision issues for large and tiny doubles and I've yet to need it. If you'd like, it might be fun to write up a test case and see why precision is getting lost.

@chadaustin chadaustin changed the title Fix conformance issues exposed by https://github.com/miloyip/nativejson-benchmark Fix double precision conformance issues exposed by https://github.com/miloyip/nativejson-benchmark Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants