Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating README #34

Open
Yannik opened this issue Jan 10, 2017 · 0 comments
Open

Updating README #34

Yannik opened this issue Jan 10, 2017 · 0 comments

Comments

@Yannik
Copy link
Contributor

Yannik commented Jan 10, 2017

Hi,

I think the README could use a few updates:

  • using the docker ansible_connection removes any need for ssh, (apart from the readme: IMO this should be used by default). this also removes any need for the whole custom routing part on mac os x.
  • actually, the service module does already work atleast with the minimal sysvinit-utils debian:jessie ships with. I would assume that this is also the case for ubuntu:16.04, but this will need verification.
  • additional documentation about the parameters the role accepts for a host should be added
  • perhaps you'd like to link my role, from what I have seen, none of the other roles that are currently linked actually make use of separating services through different container types and linking these.
  • the defaults should be documented (i.e. provision_docker_groups: ['docker_containers'] is really useful to know.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant