Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: PUT /topics/:topicId/members/users and PUT /groups/:groupId/members/users to return HTTP 422 if any of the userId-s is not a valid email or UUID. #39

Open
3 tasks
tiblu opened this issue Nov 7, 2018 · 2 comments

Comments

@tiblu
Copy link
Member

tiblu commented Nov 7, 2018

Overview

Initial implementation of PUT /topics/:topicId/members/users and PUT /groups/:groupId/members/users just ignore invalid UUID-s and e-mails. The shortcoming of this is that if you insert invalid e-mail/UUID, you will never know if the invites actually succeeded.
To provide adequate feedback, he input data should be validated and an error code returned.

TODO

  • PUT /topics/:topicId/members/users to return HTTP 422 IF any of the userId is invalid e-mail or UUID. Update tests.
  • PUT /groups/:groupId/members/users to return HTTP 422 IF any of the userId is invalid e-mail or UUID. Update tests.
  • Once done, create a task OR implement a fix in the Citizen OS FE (https://github.com/citizenos/citizenos-fe) project to update our UI to show the error.
@ilmartyrk
Copy link
Member

Seems still relevant, but needs further investigation on where and how to implement

@anettlinno
Copy link

Triage 37. Still relevant but low priority. Approx. dev. time 6 hours. Sending it to To do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog - Later
Development

No branches or pull requests

3 participants