Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom colors #26

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Custom colors #26

wants to merge 8 commits into from

Conversation

Guts
Copy link

@Guts Guts commented Nov 17, 2020

This PR document how to custom colors - close #19.

Additionally:

  • fix some minor flake8 reported errors
  • add documentation requirements in extra section in setup

@untitaker
Copy link
Collaborator

There's a lot of unrelated stuff in this PR. Can you clean that up?

@Guts
Copy link
Author

Guts commented Nov 30, 2020

There's a lot of unrelated stuff in this PR. Can you clean that up?

Maybe I should change the title but could you be more specific about the unrelated stuff in comparison with my PR description please?

click_log/core.py Outdated Show resolved Hide resolved
@@ -37,7 +35,7 @@
'theme.')
print('-' * 74)

html_static_path = ['_static']
# html_static_path = ['_static']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this file was changed either?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the flake8 message for this? All of the variables here are "unused" in flake8's view

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's just a warning spotted by Sphinx during the build.

Co-authored-by: Markus Unterwaditzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color on info level
2 participants