Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google dataset search support #63

Open
lmarini opened this issue Aug 1, 2022 · 11 comments
Open

Google dataset search support #63

lmarini opened this issue Aug 1, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@lmarini
Copy link
Member

lmarini commented Aug 1, 2022

Add required jsonld schema.org fields to pages for indexing with google data search.

@lmarini lmarini added the enhancement New feature or request label Aug 1, 2022
@MBcode
Copy link
Contributor

MBcode commented Sep 9, 2022

I can start to look at taking the mappings from v1 that would apply here, but
also want to think a little about how schema.org fields that come from class attributes
might interop with user uploaded metadata attached to the same object

@MBcode
Copy link
Contributor

MBcode commented Oct 4, 2022

Have branch: First attributes don't even need mapping after a json dump (from: get_dataset_metadata), just the addition of a 1st: "@context" : { "@vocab" : "https://schema.org/" }, element; then will have to coordinate to figure out how to get this within a <script type="application/ld+json"> w/in the dataset html; that is usr-metdata, not the internal class metadata, that we see in routers/datasets, so writing a form of to_jsonld for this w/new mapping

@MBcode
Copy link
Contributor

MBcode commented Oct 5, 2022

Have a datasetout2jsonld and wanted to know if I should put it as a route, before coordinating w/the front end?

@lmarini
Copy link
Member Author

lmarini commented Oct 6, 2022 via email

@MBcode
Copy link
Contributor

MBcode commented Oct 6, 2022

cool, I'll continue were I left a stub for it, and update here/tnx!

@MBcode
Copy link
Contributor

MBcode commented Oct 7, 2022

get_dataset_jsonld route, off of get_dataset now, so can get just one for the frontend rendering of that one dataset page, but the problem is this method gets a dict from mongo that has objids & datatimes which are not serializable, as originally needed
So for now I'm dropping those keys till I can get around that, here; just needed: dso= DatasetOut.from_mongo(dataset) to be able to dso.json() and easily remap all the keys to schema.org

@MBcode
Copy link
Contributor

MBcode commented Oct 10, 2022

Have jsonld script route will look/ask about getting into the dataset page;
just have to figure out how I should change the signature of the route, maybe end w/ /jsonld ? for this non-usr metadata. Once we agree on this I'll make a PR.
Talked w/Chen maybe Aruna can integrate

@MBcode
Copy link
Contributor

MBcode commented Oct 11, 2022

I have the working start of the sitemap which I could get it with the making the ld+json script; but think it best to take advice of having someone who knows typscript have it inserted. So this could be 2 or 3 PRs, depending on if I should include the sitemap generation now too, lmk

@lmarini
Copy link
Member Author

lmarini commented Oct 11, 2022

Can you add it to the backend as an endpoint? The frontend will have to retrieve it from there anyways.

@MBcode
Copy link
Contributor

MBcode commented Oct 12, 2022

I have the /jsonld route in, and will add the sitemap, but need a public setting to be able to crawl it
Will check dependencies for routes, /sitemap.xml also has to be open
If /summary.jsonld is open then sitemap could point to it for now

@MBcode
Copy link
Contributor

MBcode commented Oct 19, 2022

will take out of draft PR once I can open these routes, but still getting: ‘Cannot GET /sitemap.xml’ &similar for summary.jsonld route, even w/o the dependencies= line in main.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants