Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider changing tabbing #175

Open
sgratzl opened this issue Sep 18, 2021 · 5 comments
Open

consider changing tabbing #175

sgratzl opened this issue Sep 18, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@sgratzl
Copy link
Member

sgratzl commented Sep 18, 2021

image

atm there are just two tabs which seems a bit of a waste of vertical space.

Three alternatives:

  1. remove tabs and show a help/about icon on the top right showing a dialog with the current about text
  2. keep the tabs but show each targetVariable in its own tab
  3. keep the tabs but show each scoreType in its own tab
@ryantibs
Copy link
Member

Thanks @sgratzl. I don't think alternative 1 (first bullet) would be tenable because there's quite a lot of About text (goes into various details) and probably deserves its own full page. But I do like alternative 2 (second bullet): each target variable: cases, deaths, and hospitalizations being its own tab.

@sgratzl sgratzl added the enhancement New feature or request label Sep 24, 2021
@krivard
Copy link
Contributor

krivard commented Sep 29, 2021

@sgratzl let's try to get (2) completed for tomorrow; Ryan has agreed to be available to answer any questions about the details you may have.

@sgratzl
Copy link
Member Author

sgratzl commented Sep 30, 2021

not an easy change, since it requires to duplicate the evaluation tab into three ones and then decide on the server side which is the right one to write to.

@krivard
Copy link
Contributor

krivard commented Sep 30, 2021

after the 5th then

@nmdefries
Copy link
Collaborator

Another tabbing proposal #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants