Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data downloading fails if score type is coverage or if summarizing across multiple locations #255

Open
nmdefries opened this issue Mar 31, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@nmdefries
Copy link
Collaborator

We see this error

Warning: Error in filter: Problem while computing `..1 = !is.na(Score) | target_end_date >= filterDate`.
Caused by error in `mask$eval_all_filter()`:
! argument "filterDate" is missing, with no default

filterOverAllLocations requires a filterDate arg, but when totaling across locations or looking at coverage scores, we don't pass filterOverAllLocations a filterDate.

createExportScoreDataFrame will need to be passed at least a date to use in the filter. The value should be dataCreationDate to match other score-generating logic.

Consider passing input$asOf as well and adding as-of data onto the exported dataframe, to more closely match what we're using in the plots.

@nmdefries nmdefries added the good first issue Good for newcomers label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant