raft: persist Lead in HardState #124421
Assignees
Labels
A-kv-replication
Relating to Raft, consensus, and coordination.
A-leader-leases
Related to the introduction of leader leases
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-kv
KV Team
Comments
nvanbenschoten
added
C-enhancement
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
cc @cockroachdb/replication |
nvanbenschoten
added
the
A-leader-leases
exalate-issue-sync
bot
added
A-leader-leases
arulajmani
added a commit
to arulajmani/cockroach
that referenced
this issue
Jun 27, 2024
Previously, we were using raw uint64s everywhere to represent peer IDs in raft. This patch strongly types them. Informs: cockroachdb#124421 Release note: None
arulajmani
added a commit
to arulajmani/cockroach
that referenced
this issue
Jun 28, 2024
Previously, we were using raw uint64s everywhere to represent peer IDs in raft. This patch strongly types them. Informs: cockroachdb#124421 Release note: None
arulajmani
added a commit
to arulajmani/cockroach
that referenced
this issue
Jul 2, 2024
Previously, we were using raw uint64s everywhere to represent peer IDs in raft. This patch strongly types them. Informs: cockroachdb#124421 Release note: None
DarrylWong
pushed a commit
to DarrylWong/fork
that referenced
this issue
Jul 2, 2024
Previously, we were using raw uint64s everywhere to represent peer IDs in raft. This patch strongly types them. Informs: cockroachdb#124421 Release note: None
arulajmani
added a commit
to arulajmani/cockroach
that referenced
this issue
Jul 9, 2024
Previously, leader information for a given term was stored as volatile state in raft. This change persists it durably by moving it to HardState. This is done in service of leader leases, where we want to ensure a follower doesn't violate its promise of support to the leader even after a restart. Fixes cockroachdb#124421 Release note: None
arulajmani
added a commit
to arulajmani/cockroach
that referenced
this issue
Jul 12, 2024
Previously, leader information for a given term was stored as volatile state in raft. This change persists it durably by moving it to HardState. This is done in service of leader leases, where we want to ensure a follower doesn't violate its promise of support to the leader even after a restart. Fixes cockroachdb#124421 Release note: None
craig bot
pushed a commit
that referenced
this issue
Jul 17, 2024
126898: raft: persist Lead into the HardState r=nvanbenschoten a=arulajmani Previously, leader information for a given term was stored as volatile state in raft. This change persists it durably by moving it to HardState. This is done in service of leader leases, where we want to ensure a follower doesn't violate its promise of support to the leader even after a restart. Fixes #124421 Release note: None 126970: sql/sem/tree, backupccl, *: sanitize URLs during Format r=dt,rytaft a=michae2 Prior to this change, all SQL statements containing URLs would be formatted with the full URL in cleartext, including any secrets such as keys or passwords. These secrets would sometimes show up in the slow query log or sql audit log. This PR adds new functions `tree.(*FmtCtx).FormatURI`and `tree.(*FmtCtx).FormatURIs` which are designed to sanitize URLs during formatting. See individual commits for details. Fixes: CRDB-39710, TREQ-284 Epic: None Release note: None Co-authored-by: Arul Ajmani <[email protected]> Co-authored-by: Michael Erickson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
raft.leadis currently volatile state which is lost on restart. We should add this toHardStateand make it durable. This will pair with theLeadEpochfield that we plan to add toHardStateas part of the leader-lease project.Related to #122446.
Jira issue: CRDB-38884
Epic CRDB-37522
The text was updated successfully, but these errors were encountered: