Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: support for adminer #40391

Open
awoods187 opened this issue Aug 30, 2019 · 2 comments
Open

sql: support for adminer #40391

awoods187 opened this issue Aug 30, 2019 · 2 comments
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@awoods187
Copy link
Contributor

awoods187 commented Aug 30, 2019 •
edited by jordanlewis
Loading

adminer
Version: 4.7.2
A custer received an error trying to list tables in the database.

Compared to pgsql (#40390), at least adminer list all the databases.

The customer received this error:
image

Blocked by #86017

Jira issue: CRDB-5540
@awoods187 awoods187 added A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Aug 30, 2019
@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021
@gnat
Copy link

gnat commented Nov 7, 2022 •
edited
Loading

After using many tools with CockroachDB, Adminer is honestly one of the better ones by a wide margin (all you need is php -S localhost:8888 -t adminer to run it, even directly off of a server, and it's just a standalone all-in-one php file). Works if you comment out this part of the query at: https://github.com/vrana/adminer/blob/88647b93e467210f270340e758af6771e2c5638a/adminer/drivers/pgsql.inc.php#L325

It's such a small modification to the Postgres driver to have it work, I would submit a PR but @vrana hasn't merged any PR's for quite some time, sadly. 👀 Hope he's okay!

Ideally, would love to see a similar UI just built into CockroachDB's web UI, but Adminer is definitely underrated.

@gnat
Copy link

gnat commented Nov 24, 2022 •
edited
Loading

Uploaded my branch that works with CockroachDB, based on the Postgres driver.

Not sure if I'll be able to allocate time to polish it, but it was only a few changes to make it mostly functional.

vrana/adminer#461

Would love to just see something like adminer for table creation / browsing built into the Cockroach UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gnat @rafiss @awoods187