-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to complete localization of text throughout the app #344
Comments
I've wanted so badly to contribute to something open source. This feels like low hanging fruit that I can handle. I'll take a stab at this and submit a pull request. Thanks! |
@tannerj Great! Thanks for doing this. |
No problem, I'm working on it now. A few questions.
|
Those are good questions. I think distinguishing between nav and buttons is a good idea, but repeating the same text is probably not. |
…ation and buttons in views and specs. Admin buttons are namespaced with "admin".
Just a quick update, I haven't abandoned this. I've been on vacation/out of town constantly for the last 3 weeks, I'm hoping to spend some time on this over the next week. Sorry for the delay. |
There are still many places where text can and should be localized so that it can more easily be translated in non-English deployments.
To fix:
Find text that can be localized (such as notices, error messages, button text, labels, help text, etc.)
Copy and paste it into a new entry in config/locales/en.yml and use keys that relate to the text. For example, if you're localizing a button, add a new
buttons
key, and then a separate key that describes each button, such as:Replace the text in the code with a reference to the localization by using the
t
helper, like this:If you're not in a view template, you'll need to use
I18n.t
instead of thet
shortcut.The text was updated successfully, but these errors were encountered: