Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

after() should be able to take a iTask instance #18

Open
bastianschwarz opened this issue Jun 2, 2023 · 0 comments
Open

after() should be able to take a iTask instance #18

bastianschwarz opened this issue Jun 2, 2023 · 0 comments
Assignees
@bastianschwarz
Labels
enhancement New feature or request good first issue Good for newcomers php Pull requests that update Php code

Comments

@bastianschwarz
Copy link
Member

The Default deployer after() expects a string or closure so passing task instances won't work.

We should check for that and wrap it in a closuer and pass it on in that case.
@bastianschwarz bastianschwarz added enhancement New feature or request good first issue Good for newcomers php Pull requests that update Php code labels Jun 2, 2023
@bastianschwarz bastianschwarz self-assigned this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bastianschwarz bastianschwarz

Labels
enhancement New feature or request good first issue Good for newcomers php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bastianschwarz