Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain GUI views are eating up performance #37

Open
cohaereo opened this issue Jul 27, 2024 · 3 comments
Open

Certain GUI views are eating up performance #37

cohaereo opened this issue Jul 27, 2024 · 3 comments
Labels
bug Something isn't working feature A new feature
Milestone

Comments

@cohaereo
Copy link
Owner

The inspector eats up about 5ms of frametime
alkahest_mGdm9NZKjM
alkahest_DSunwmfnG4

The About menu is by far the worst, presumably due to my crappy implementation of the egui image loader
alkahest_d4CiAVlttu

@cohaereo cohaereo added bug Something isn't working feature A new feature labels Jul 27, 2024
@Froggy618157725
Copy link
Collaborator

For inspector, it is specifically static instance, not static instances. Terrain is also fine.

@cohaereo
Copy link
Owner Author

cohaereo commented Sep 3, 2024

The cause of the performance hit in the inspector was caused by the continuous polling of the distance from the camera to the fragment under the crosshair, as this was pulling depth buffer data synchronously each frame, causing significant slowdowns.

The polling behaviour has been removed since c863cf5, may be reimplemented in the future with a better distance testing solution

@cohaereo cohaereo added this to the 0.5.1 milestone Dec 29, 2024
@cohaereo
Copy link
Owner Author

The polling behaviour has been removed since c863cf5, may be reimplemented in the future with a better distance testing solution

We could use collision detection for this, once that's implemented

Pros:

  • A lot faster than depth buffer testing
  • Works with solid transparent objects like glass

Cons:

  • Any non-solid objects (eg. out of box geometry) won't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants