From f628091793bfebc2653be956ecb40b25dc637cfc Mon Sep 17 00:00:00 2001 From: Marco Esters Date: Wed, 8 May 2024 14:43:26 -0700 Subject: [PATCH 1/2] Fix OS name in test matrix for AzureSignTool installation --- .github/workflows/main.yml | 2 +- docs/source/howto.md | 1 + news/771-add-azure-signtool-support | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d88f243d4..e668c330e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -95,7 +95,7 @@ jobs: environment-file: dev/environment.yml python-version: ${{ matrix.python-version }} - name: Install AzureSignTool - if: matrix.os == 'windows' + if: startswith(matrix.os, 'windows') run: dotnet.exe tool install --global AzureSignTool shell: pwsh - name: Supply extra dependencies and install constructor diff --git a/docs/source/howto.md b/docs/source/howto.md index c8701f00b..a5a8e54d4 100644 --- a/docs/source/howto.md +++ b/docs/source/howto.md @@ -87,6 +87,7 @@ For each tool, there are environment variables that may need to be set to config If neither `AZURE_SIGNTOOL_KEY_VAULT_ACCESSTOKEN` nor `AZURE_SIGNTOOL_KEY_VAULT_SECRET` are set, `constructor` will use a Managed Identity (`-kvm` CLI option). ::: + ### Signing and notarizing PKG installers In the case of macOS, users might get warnings for PKGs if the installers are not signed _and_ notarized. However, once these two requirements are fulfilled, the warnings disappear instantly. diff --git a/news/771-add-azure-signtool-support b/news/771-add-azure-signtool-support index eb7a47aaf..10f5b6d24 100644 --- a/news/771-add-azure-signtool-support +++ b/news/771-add-azure-signtool-support @@ -1,6 +1,6 @@ ### Enhancements -* Add support for AzureSignTool to sign Windows installers. (#767 via #771) +* Add support for AzureSignTool to sign Windows installers. (#767 via #771 and #790) ### Bug fixes From 0ecc14236167950279a31d5018b9a0954b1f4ff3 Mon Sep 17 00:00:00 2001 From: Marco Esters Date: Wed, 8 May 2024 14:45:39 -0700 Subject: [PATCH 2/2] Correct PR number in news --- news/771-add-azure-signtool-support | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/news/771-add-azure-signtool-support b/news/771-add-azure-signtool-support index 10f5b6d24..26be0c1b1 100644 --- a/news/771-add-azure-signtool-support +++ b/news/771-add-azure-signtool-support @@ -1,6 +1,6 @@ ### Enhancements -* Add support for AzureSignTool to sign Windows installers. (#767 via #771 and #790) +* Add support for AzureSignTool to sign Windows installers. (#767 via #771 and #792) ### Bug fixes