Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locking issue in tsi_release #80

Open
justxuewei opened this issue Dec 3, 2024 · 1 comment
Open

Locking issue in tsi_release #80

justxuewei opened this issue Dec 3, 2024 · 1 comment

Comments

@justxuewei
Copy link

I don't see anywhere to acquire lock in tsi_release, but the lock is released in the end. Is it right?

static int tsi_release(struct socket *sock)
{
    // ...
    release_sock(sk);
}
@justxuewei
Copy link
Author

Another issue is that sock_alloc() allocates socket and inode, calling sock->ops->release() is not enough to release all resources, calling sock_release() instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant