Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persistent failure on macys #137

Open
bqpd opened this issue Aug 29, 2019 · 9 comments
Open

persistent failure on macys #137

bqpd opened this issue Aug 29, 2019 · 9 comments
Assignees

Comments

@bqpd
Copy link
Contributor

bqpd commented Aug 29, 2019

Geometric Program is not fully bounded:
   Mission1.Aircraft.Engine.EngineConstants.Relax1.R has no lower bound
   Mission1.Aircraft.Engine.EngineConstants.Relax1.g has no lower bound

https://acdl.mit.edu/csi/view/convexengineering/job/gplibrary_Push_Models/189/buildnode=macys,optimizer=mosek/testReport/junit/gpkit.tests.from_paths/TestFiles/test_SPaircraft_py_mosek/

This looks like a divergent approximation (perhaps of a feasibility solve) that occurs after a few GP solves. May be fixed by switching to CCP solves?

@bqpd
Copy link
Contributor Author

bqpd commented Aug 29, 2019

Regardless, if this isn't fixed soon I'll have to take SPaircraft off of GPkit PR tests until it is. :-/

@1ozturkbe
Copy link
Contributor

Oy! I will try to fix this as soon as I can... I do think it is an issue in turbofan unfortunately...

@whoburg
Copy link
Collaborator

whoburg commented Sep 1, 2019

I assume this is a side effect of one of @1ozturkbe 's recent PRs merged on turbofan? I would much rather see a hacky fix on turbofan (e.g. add an artificial bound on R and g) along with keeping this issue open until that's sorted out, over removing this repo from GPkit tests.

@1ozturkbe
Copy link
Contributor

I will take a look today and let you know.

@bqpd
Copy link
Contributor Author

bqpd commented Sep 4, 2019 via email

@bqpd
Copy link
Contributor Author

bqpd commented Sep 4, 2019 via email

@1ozturkbe
Copy link
Contributor

argh, I really don't know why this is failing... I may have to hack the model for now to get it to work... I will get it done.

@1ozturkbe
Copy link
Contributor

Argh again, the CPU usage on my ACDL machine is literally 100% on all CPUs, so this will have to wait a little.

@1ozturkbe
Copy link
Contributor

I haven't touched this in a while... I guess time to dig it back up. The reason this is failing is because the engine is giving completely unphysical results when coupled to SPaircraft, mainly in saying fuel burn is 1/10th the original sol'n. No idea why this is happening, because the models are identical to before. Going to PR a fix, but it will definitely not be a satisfactory solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants