Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmaRefresh cleaning entire node_modules folder #31

Open
borgiani opened this issue Jun 9, 2017 · 4 comments
Open

karmaRefresh cleaning entire node_modules folder #31

borgiani opened this issue Jun 9, 2017 · 4 comments

Comments

@borgiani
Copy link

borgiani commented Jun 9, 2017

Hi, when running the karmaRefresh task (which depends on karmaClean), the entire node_modules folder is being cleaned.
This is not very efficient in CI environments, because it causes the CI system to have to reload all node modules on every build.
By looking at the code, it seems the issue could be caused by: https://github.com/craigburke/karma-gradle/blob/master/src/main/groovy/com/craigburke/gradle/KarmaPlugin.groovy#L98

I'm guessing that replacing it with file should fix it.

Thanks!

@borgiani
Copy link
Author

Suggested fix: #32
Have you had the chance to review this @craigburke ?

@drschulz
Copy link

@craigburke Adding this fix would be greatly appreciated! I have other libraries in my project, and it takes forever to do a fresh build because of this issue.

@asoftwareguy
Copy link

+1

@borgiani
Copy link
Author

borgiani commented Feb 5, 2018

@craigburke any chance you may have a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants