Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karma config should not use root dir #8

Open
musketyr opened this issue Feb 9, 2016 · 4 comments
Open

karma config should not use root dir #8

musketyr opened this issue Feb 9, 2016 · 4 comments
Milestone

Comments

@musketyr
Copy link

musketyr commented Feb 9, 2016

in case of multiproject build you get the root directory of the very first parent

see https://github.com/craigburke/karma-gradle/blob/master/src/main/groovy/com/craigburke/gradle/KarmaPlugin.groovy#L106

therefor no tests are being executed

@craigburke
Copy link
Owner

@musketyr huh... I'll have to think about this one. I think you could probably make the case for either way depending on how your project is set up.

It's a default value and can be explicitly set to whatever you'd like, but ideally that default would work for most people.

@musketyr
Copy link
Author

musketyr commented Feb 9, 2016

Well, if you run karmaRun in a project, you want to test just the given
project not all siblings projects in case of multiproject builds...

Dne út 9. 2. 2016 17:58 uživatel Craig Burke [email protected]
napsal:

@musketyr https://github.com/musketyr huh... I'll have to think about
this one. I think you could probably make the case for either way depending
on how your project is set up.

It's a default value and can be explicitly set to whatever you'd like, but
ideally that default would work for most people.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@craigburke
Copy link
Owner

@musketyr that's a fair point. It probably would be a more reasonable default.

@craigburke craigburke added this to the 1.5.0 milestone Apr 15, 2016
@testinfected
Copy link
Contributor

I agree with @musketyr. Module root seems a better default.

We're having the same issue. This forces us to repeat the module prefix in all config paths.

Other than that, great plugin, thanks @craigburke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants