Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Error pages are not styled/themed #532

Open
1 task
TimidRobot opened this issue Apr 24, 2024 · 7 comments
Open
1 task

[Feature] Error pages are not styled/themed #532

TimidRobot opened this issue Apr 24, 2024 · 7 comments
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@TimidRobot
Copy link
Member

TimidRobot commented Apr 24, 2024

Problem

Error pages are not styled/themed

Current 404 page:
Screenshot 2024-04-24 at 11-47-50 Page not found · GitHub Pages

Description

The error pages should not disrupt the user experience

Alternatives

Do nothing

Additional context

Implementation

  • I would be interested in implementing this feature.
@TimidRobot TimidRobot added 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work ✨ goal: improvement Improvement to an existing feature 🕹 aspect: interface Concerns end-users' experience with the software labels Apr 24, 2024
@akshansh-modi
Copy link

akshansh-modi commented Jun 18, 2024

@TimidRobot I would be interested in implementing this feature. , could you please assign this to me

@TimidRobot
Copy link
Member Author

@TimidRobot I would be interested in implementing this feature. , could you please assign this to me

@akshansh-modi Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs.

We generally don't assign issues prior to resolution. Instead of asking for issues to be assigned, do the work and submit a pull request (PR). Even if multiple people submit PRs for the same issue, multiple ideas and implementations strengthen the final product.

@ankur-kalita
Copy link

hey @TimidRobot I want to contribute to this issue , could you assign me this issue

@kritika-76
Copy link

hello !
actually i want some help from you to start the project and how to start .
i am the beginner and i am trying to do projects .
but by some queries , i won't make it.
can you please help me as a mentor?

@saikatsardar01
Copy link

@TimidRobot How about this page?

404-page-uh-oh-you-re-lost.mp4

@saikatsardar01
Copy link

If you like it I can give a pull request

@egbadon-victor
Copy link
Contributor

egbadon-victor commented Nov 5, 2024

@TimidRobot @possumbilities I was doing research on the implementation of this.

Could this be implemented upstream in the vocabulary repository. The reason for this thinking is as follows;

  • All CC ancilliary sites don't have a uniform error page implementation.
  • All sites have the same class of errors that could occur (i.e 4xx, 5xx etc), hence a design system can effectively accomodate these variations.

While a PR can be submitted for this specifically for this issue, I think it would be a great opportunity to standardize the error page structure.

Here is how I would go about it;

  1. Implement the error page styles in the vocabulary repository, along with creating a specimen in the context folder, to visaulize the error page, collaborating with project maintainers for feedback.
  2. Update the vocabulary version of the chooser repo to reflect the error styles update
  3. Implement the error page in the chooser repo, following the approved design system arrived at in step 1.

Please let me me know what you think about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Status: Backlog
Development

No branches or pull requests

6 participants