Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve responsiveness of ancillary-menu #80

Open
1 task done
oka4shi opened this issue Nov 13, 2024 · 1 comment
Open
1 task done

[Feature] Improve responsiveness of ancillary-menu #80

oka4shi opened this issue Nov 13, 2024 · 1 comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@oka4shi
Copy link

oka4shi commented Nov 13, 2024

Problem

Now, the language selection is overflowing in the ancillary menu of cc-legal-tools-app. (See: cc-legal-tools-app#418).

Description

We need to set the font size in more detail to fix this. I wrote CSS like this and the problem was fixed in my PR:

.ancilliary-menu {
  font-size: min(.8em, 2.5vw);
}

Additional context

I created a PR for the cc-legal-tools-app and overrode the font size of .ancilliary-menu. This needs to be fixed cc-legal-tools-app#418 without using Media queries/breakpoints.

Alternatives

Media queries/breakpoints can be used to specify font size, but I think this method is better.

Implementation

  • I would be interested in implementing this feature.
@oka4shi oka4shi added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Nov 13, 2024
@oka4shi oka4shi changed the title [Feature] Improve responsivility of ancilliary-menu [Feature] Improve responsiveness of ancilliary-menu Nov 13, 2024
@possumbilities possumbilities added 🚧 status: blocked Blocked & therefore, not ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 13, 2024
@possumbilities possumbilities moved this from Triage to Backlog in possumbilities Nov 13, 2024
@possumbilities
Copy link
Contributor

@oka4shi This is something that would need to be fully resolved in Vocabulary itself, and then we'd update vocabulary-theme with the latest Vocabulary.

Additionally, the cc-legal-tools-app has made several more localized changes to the language selector styling that are not present in Vocabulary itself. That would likely need resolution as well, and then possibly further changes in cc-legal-tools-app to remove said localized changes.

Moving to 🚧 status: blocked Blocked & therefore, not ready for work until Vocabulary itself is altered to account for this.

@possumbilities possumbilities changed the title [Feature] Improve responsiveness of ancilliary-menu [Feature] Improve responsiveness of ancillary-menu Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work
Projects
Status: Backlog
Development

No branches or pull requests

2 participants