Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dojo build] modules inside has in config.json don't get included automatically #5

Open
csantanapr opened this issue Jun 25, 2013 · 2 comments

Comments

@csantanapr
Copy link
Owner

if you have something like this in config.json

"has": {
    "html5history": {
        "controllers": [
            "dojox/app/controllers/History"
        ]
    },
    "!html5history": {
        "controllers": [
            "dojox/app/controllers/HistoryHash"
        ]
    }
}

then dojox/app/controllers/History and dojox/app/controllers/HistoryHash don't get discover by dojox/app/build/discoverAppConfig to be inserted into layer

Need to included manually in app.profile.js

include: [ 
            'dojo/i18n', 
            'dojo/domReady', 
            'dojo/text', 
            'dojox/json/ref', 
            'app/main', 
            'app/run',
            //Add App Framework
            'dojox/app/main',
            //Add any modules inside a has in the config.json
            //I think this is a bug in dojo/app/build/discoverAppConfig.js
            'dojox/app/controllers/History',
                    'dojox/app/controllers/HistoryHash'
],
@csantanapr
Copy link
Owner Author

The workaround is kind of manual for now, if the modules inside "has" are added to the dependencies array then they are force to be include, I think its still useful if dojox/app/build/discoverAppConfig.js could take a look at has and see if the modules need to be included in build.

@cjolif
Copy link

cjolif commented Jun 25, 2013

See dmachi/dojox_application#193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants