Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create explicit init and login methods #24

Open
xpt1x opened this issue Feb 10, 2023 · 0 comments
Open

Create explicit init and login methods #24

xpt1x opened this issue Feb 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@xpt1x
Copy link
Member

xpt1x commented Feb 10, 2023

As UIMS has imposed restrictions for accessing UIMS data by protecting Login mechanism with a captcha

This library at current structure can't comply to it, so we should now create explicit initialize and login method for the session instance where:

  • initialize(credentials) - will initialize the instance with relevant user login data (like credentials) and will return a captcha url
  • login(captcha) - will have captcha as a parameter, after this session will be a valid session and can properly access other properties like full_name and attendance otherwise an error will be thrown if session is not valid (i.e improperly init)

Projects relying on this library can present user with the captcha image provided by initialize to solve and call login method with answer to this captcha

Ofcourse naming can be changed but it should be a two step process now

@xpt1x xpt1x added the enhancement New feature or request label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant