Navigation bar appears at the wrong height when switching back to Eateries tab

[whoiswillma]

Recreate:

1. Open eateries page and open an eatery
2. Open lookahead tab
3. Go back to eateries page
4. Use the left-swipe gesture to go back to the Eateries page
5. The navigation bar is now too high up, but this fixes itself when you scroll or do anything

[whoiswillma]

If someone decides to pursue this bug in the future: here's what I've learned.

• The bug is caused by hiding and showing the navigation bar while a search bar exists. It seems like a bug with UINavigationController. Admittedly, showing and hiding the nav bar is a bit suspicious. But it works perfectly without a search bar, and even has a custom animation (see Transit iOS pushing the routes VC)

• If you remove the fake navigation bar in CampusMenuViewController (added by its superclass) and replace it with the real navigation bar, then you encounter ANOTHER bug with UINavigationController and Hero. EIther Hero specifies the wrong animation duration, or the navigation controller doesn't animate the navigation bar properly. In either case, the navigation bar is still animating after the view becomes interactive. If you try implementing this:

  1. Open the menu for an Eatery at the top of the page
  2. Press the back button in the top left
  3. Spam-press where another Eatery will be (or learn the timing and press it while the nav bar is still animating)
  4. Watch the search bar be stuck in the middle of the screen

So I've abandoned this strategy.

• I've given up on this for now, but to future me (or someone else), try forcing the navigation bar to recompute its frame just a moment after the user releases their finger. Either that, or replace the navigation bar on the EateriesViewController with another fake navigation bar