-
-
Notifications
You must be signed in to change notification settings - Fork 528
What is required to add a language to the upstream set polyglot
#594
Comments
Essentially we use something in our documentation that renders part of the page as "common" and part of the page as language specific. So if you check out the repo you'll see syntax like this:
This means that the text will only render for the java / kotlin sections. So to start with you should be able to submit some PR's with a new tag notation for rust. The only other bit we would need to do would be to add the incorporation of that new tag. It's likely that until we incorporate the new tag, it would either not show at all or it would show as plaintext. To get it activated I would probably defer to @aslakhellesoy or @mlvandijk as the last one we added was Kotlin I believe. But at least you know now you can start work on some documentation if you so desire. I hope that helps! EDIT: To test out the theory of what it would do. If you create a small PR that adds it to one of the pages, we can then preview the page in our CI. This would tell you whether you can add the docs as "invisible" which would probably aide you so we're not a blocker or not. |
polgot
polygot
polygot
polyglot
Thank you for the prompt response. This sounds very promising. To make sure I understand your response:
The workflow we can develop - I'll try to workout the invisible setting. |
|
I'm don't know what cucmber.io will maintain and what they won't - they is nothing stopping cucumber Org forking a project to be under its Org and pulling in changes if they want them, and passing on any PR the cucumber Org receives. I'm working on documenting cucmber-rust in a way that the project doesn't sit siloed from the wider Cucumber community.
Apologies for being unclear.
You gave some instructions about how to add implementation specific code to the user docs. So it appears there is no minimum level of compatibility for an implementation usage docs to be included upstream - or you would have replied to the effect we require x, y, z compatibility, etc. To avoid confusion I then stated ("To make sure I understand your response"), in 4 points, my understanding of what your response meant. I have opened Cucumber issue #1400.
No worries. Current and past self are often as distinct as two different people. Adding user facing doc to cucmber.io will be an effort that will be incremental and take time so I'll push to the cucumber.io docs site when I can. Yes it would be useful to have a visibility switch. I'll try to push some small doc change, but I wasted a day not-figuring out the CCK, so it'll have to wait some time. If there is some need or utility to having cucumber-rust sit under the Cucumber org, just fork it and push any contributions you receive back to @bbqsrc - he raised no objections when I did that, in fact I think that is why he used the licenses he has. |
We recently discussed this in the weekly community meeting. It's really hard to maintain the current polyglot doc structure, and we're leaning towards abandoning it and pointing users towards implementation-specific documentation in Markdown files on GitHub. |
Appreciate the difficulty, and all the work that has gone into cucumber.io. Happy either way happy for this to be closed as you see fit. |
In the upstream docs there are links that render language specific versions of the page.
In this repository these are languages that are part of a
polygot
set/list.What is required for a language to have its documentation included upstream as a member of the
polygot
set/list?We're contemplating embarking on documenting the cucumber-rust project and would like to do so in a way that allows the Rust documentation to be upstream.
Or at least initially gives us a set of requirements we can cite and target for inclusion upstream.
The text was updated successfully, but these errors were encountered: