-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-store: incorrect information for n>0 xtriggers #6298
Comments
2 is a no go for me (like you said, just as confusing) I think 1 is a good option Is the prerequisites |
I agree with David, option 1 is best. |
Ok, this looks like a consensus, going with option 1. |
cylc-flow/cylc/flow/scripts/show.py Line 344 in a991fae
|
* Closes cylc#6298 * The `cylc show` command will now convey if an xtrigger has not yet started polling so that it doesn't look like n>0 xtriggers are not satisfied even if the external condition they will poll for is
* Closes cylc#6298 * The `cylc show` command will now convey if an xtrigger has not yet started polling so that it doesn't look like n>0 xtriggers are not satisfied even if the external condition they will poll for is
Xtriggers are not evaluated until at least one pre-requisite has been satisfied (where the "runahead limit" is effectively handled as a prerequisite for parentless tasks for this purpose), however, Cylc interfaces e.g.
cylc show
will list them irrespective.This can cause confusion. E.g. If you inspect a runahead-limited task with a
wall_clock
xtrigger, the xtrigger may be shown as unsatisfied despite being past the trigger time. This is a bug as Cylc is making it look like awall_clock
xtrigger is returningFalse
rather than explaining that it hasn't started running yet.Proposal
Xtriggers should have one of three states meaning "satisfied", "unsatisfied" or "not yet evaluated" (exact names TBC).
The
cylc show
CLI and "Info View" in the GUI should represent this "not yet evaluated" state in an intuitive way.Options Considered
The text was updated successfully, but these errors were encountered: