Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance DeviceFactory to use Message #46

Open
cartemere opened this issue Feb 28, 2019 · 0 comments
Open

enhance DeviceFactory to use Message #46

cartemere opened this issue Feb 28, 2019 · 0 comments

Comments

@cartemere
Copy link
Collaborator

DeviceFactory is very limited, as it is based exclusively on the message attribute keys (TEMP, WIND, HUM, SWITCH, CMD...)
It can NOT handle complex algorithm, or even take advantage of the message protocol.
Therefore, input RTS messages from the bridge can NOT be mapped to a RTS device, as the discriminant is not a message attribute key, but the attribute protocol.

Moreother, the current implementation is buggy (HUMIDITY & TEMP Devices are never created, OregonTempHygro is instantiated instead).

DeviceFactory should be improved to use the whole Message.

cartemere added a commit to cartemere/org.openhab.binding.rflink that referenced this issue Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant