-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marginal density/histogram to geom_hex #27
Comments
You can do that right now. Just call
|
For your information, I'd like to let @daattali know that Example: (R: 3.6.1, ggplot2: 3.2.1, ggExtra: 0.9) library(ggplot2)
library(ggExtra)
p1 <- ggplot(mtcars, aes(wt, mpg))
ggMarginal(p1 + geom_point(), type = "density") ggMarginal(p1 + geom_hex(), type = "density")
#> Error: No geom_point layer was found in your scatter plot
ggMarginal(p1 + geom_hex(), type = "histogram")
#> Error: No geom_point layer was found in your scatter plot Created on 2019-11-27 by the reprex package (v0.3.0) |
Thanks. You could technically still do it with ggExtra by also adding
But I'll reopen the issue since that's not a great solution |
@daattali , do we want to relax the assumption that there has to be a geom_point layer for ggMarginal to try to create the marginals? In other words, do we want to check if there is either geom_point or geom_hex moving forward, as opposed to requiring there be a geom_point layer? |
I'm comfortable with that, under the assumption that it will also work correctly of course :) I tried seeing what happens if we check for point OR hex, and didn't change anything else, and the results are incorrect because the marginal density treats the hex as if they are regular points, disregarding the density that each hex point conveys.
|
Ergh, you're right. It would be possible to use the underlying data, but it would add additional complexity to the codebase and I don't think it would be worth it. I'm partial to simply requiring that a geom_point layer be used. |
Agreed. This can remain open as I'm not opposed to supporting it if a natural solution presents itself |
It will be nice to able to show geom_hex along with two densities on top and right since there are circumstances where scatterplot is too slow due to the huge number of events.
The text was updated successfully, but these errors were encountered: