Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to tertiary navigation in Moodle 4 #92

Open
t-schroeder opened this issue Oct 13, 2023 · 2 comments
Open

Move to tertiary navigation in Moodle 4 #92

t-schroeder opened this issue Oct 13, 2023 · 2 comments

Comments

@t-schroeder
Copy link

Currently in Moodle 4 this plugin adds itself in the secondary navigation. So you end up with one entry for "Course completion" and one for "Course recompletion":

image

In the interest of keeping the secondary navigation short I'd suggest adding it instead to the tertiary navigation (i.e. the dropdown at the top) on the "Course completion" page:

image

@danmarsden
Copy link
Owner

I hear where you're going there but I'd worry about doing that on stable releases - but yes I do think it would probably make sense to move both the recompletion and modify course completion dates pages to the tertiary nav on the course completion page - but, moving links into tertiary navigation risks stuff like this:
https://moodle.org/mod/forum/discuss.php?d=451477

which could compound a lot more if we did it on the stable branches.... :-)

@danmarsden
Copy link
Owner

I wonder if we should add a new config setting that changes where it sits - by default it could drop it into the tertiary navigation and we could write an upgrade step that checks "does the site have any existing recompletions set" and if so, enable the setting to show it in the secondary nav so that existing sites won't find the link moving and getting lost?

would be great if someone wanted to fire through a PR to do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants