Remove uses of deprecated constants from packages used by flutter and internal code

[leafpetersen]

Identify and clean up any packages that are used by flutter or by internal code and which still use the deprecated CONSTANTS. Main issue here: #31813 .

[leafpetersen]

@kevmoo I believe you looked at packages to identify ones that would need clean up. Do you still have this data? Can you provide this so that we can cross reference against packages used in flutter and internally?

[kevmoo]

I *DON'T* have this data – at least not directly available. We'd have to dig through the analysis data from the package site. Doable, but it'd take some scripting. Contact me offline...

…

On Tue, Apr 3, 2018 at 8:52 AM Leaf Petersen ***@***.***> wrote: @kevmoo <https://github.com/kevmoo> I believe you looked at packages to identify ones that would need clean up. Do you still have this data? Can you provide this so that we can cross reference against packages used in flutter and internally? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32749 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCikHD5Qw8tGWEf1zA9vmISI0Z0jFRks5tk5q3gaJpZM4TFVOL> .

[dgrove]

What's the next step here? Is there any further work required for beta 3?

[kevmoo]

We have 41 packages that use at least one of these constants. Some of them are used by Flutter. We need to get them updated and published...

Not sure where @nex3 is with https://github.com/dart-lang/dart2_constant

[nex3]

Not sure where @nex3 is with https://github.com/dart-lang/dart2_constant

It's released and announced.

[leafpetersen]

It's not clear to me that there is any reason that we need to have these updated and published by Beta-3, since updating the packages is non-breaking to users of the packages (including flutter). Is there something I'm missing? Certainly doesn't hurt to get them done ASAP though.

The intersection of @kvemoo's list of packages from the top 200 that need fixing and packages depended on by flutter is enclosed below. There may be other flutter packages that need fixing that aren't in the top 200 though, so we need to go through and verify at some point.

These packages are used by flutter and need fixing (there may be others):

EDITED: added packages used in sdk that currently use SCREAMING CAPS (at last the version in DEPS)

• analyzer
• async
• barback
• coverage
• crypto
• csslib
• dart2js_info
• dart_style
• html
• http
• http_io
• http_parser
• http_retry
• http_throttle
• image
• intl
• intl_translation
• isolate
• json_rpc_2
• json_schema
• markdown
• matcher
• mime
• mockito
• mustache4dart
• oauth2
• package_resolver
• pool
• process
• protobuf
• pub
• quiver
• resource
• shelf
• shelf_static
• shelf_web_socket
• source_maps
• stream_channel
• test
• test_process
• usage
• vector_math
• yaml

[devoncarew]

What is the sdk lower bounds where the constants were introduced (or, are all available)?

[devoncarew]

I see some packages using: sdk: '>=2.0.0-dev.30 <2.0.0'.

[lrhn]

I believe the lower-case constants were released in 2.0.0-dev.17.0

I'm already working on the packages that are used by the SDK, but let's see if I can make proper pull requests for them.

[leafpetersen]

Added the list of packages used by the sdk to the TODO list above.

[dgrove]

@lrhn any idea when the changes for these packages can land?

[dgrove]

@lrhn any updates?

[lrhn]

I have pull requests out for all the packages in the above list that need it.
Some are entirely third-party, and I don't know how soon those will be handled. We do not control publishing of those (e.g., mustache4dart, which has a dart2 branch, but no releases of it).
Some packages are internal, and some of those are blocked on review (due to review vacation).
Some have already landed.

It's unclear what our strategy for barback is. It's not planned to be upgraded to Dart 2, so we should remove it from the SDK ASAP since it has no future.

The sooner we make the SDK Dart 2 only, the sooner such issues will be surfaced.

[leafpetersen]

@grouma what's the story on barback?

[grouma]

It's been removed entirely from pub and is no longer supported: 94f45c8

[leafpetersen]

So can we stop pulling barback into the SDK now?

[kevmoo]

I think if we update pkg:test, yes...I think...

…

On Tue, May 15, 2018 at 4:07 PM Leaf Petersen ***@***.***> wrote: So can we stop pulling barback into the SDK now? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32749 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCisXtCRgTsVhXeX-2jjCqlgHDl69rks5ty1-cgaJpZM4TFVOL> .

[leafpetersen]

https://dart-review.googlesource.com/c/sdk/+/55321

[dgrove]

Any updates here?

[kevmoo]

Looks like we still have watcher, markdown, and source_maps not updated and published – of those in the SDK

[dgrove]

/cc @nex3 @sigmundch @munificent - can you publish watcher/source_maps/markdown with new constants?

[dgrove]

watcher was published 25 June 2018, with new constants.
markdown was published 2 July 2018 - not sure if this has the updated constants. @munificent / @srawlins - do you know?

[munificent]

I haven't looked into markdown. If @srawlins doesn't reply, I'll take a look.

[srawlins]

I'll do markdown tonight.

[srawlins]

Oh, Leaf did it.

[vsmenon]

Any updates on this? Do we have any further changes needed on packages hosted in the sdk repo?

[kevmoo]

Here's our packages. googleapis is important for the Flutter folks – I think that's the only one we should worry about...

[leafpetersen]

googleapis is not in the transitive closure of the DEPS of the flutter repo, why do you say it's important for them?

The only thing that I know of that is required for flutter is json_schema. I have a PR here that needs some love: Workiva/json_schema#26 .

[leafpetersen]

Once we have a successful roll to flutter this can be closed.

[kevmoo]

SGTM. I know there are folks in the flutter universe that use the Google APIs – so it might come up.

…

On Wed, Jul 25, 2018 at 10:00 AM Leaf Petersen ***@***.***> wrote: Once we have a successful roll to flutter this can be closed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32749 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCigfobkIEVgbYSBeYTbrrDl2P4OEBks5uKKQmgaJpZM4TFVOL> .

[leafpetersen]

This is done, we've rolled flutter and internal.

[tonyclickspace]

chrome.dart still has instances of JSON.decode:
dart-gde/chrome.dart#278
Not sure if that's high enough priority to re-open this.

[leafpetersen]

There's an open PR for chrome.dart (dart-gde/chrome.dart#272), but the scope of this bug is packages used directly by flutter or internal code which I believe is now complete.