Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove phone validation check #13341

Closed
2 tasks
mmiddaugh opened this issue Apr 27, 2021 · 1 comment
Closed
2 tasks

remove phone validation check #13341

mmiddaugh opened this issue Apr 27, 2021 · 1 comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) sitewide Technical debt VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@mmiddaugh
Copy link
Contributor

mmiddaugh commented Apr 27, 2021

Issue Description

Currently, phone numbers are validated to confirm they contain 10 digits. This is no longer needed and can be removed to simplify the code.

Engineering Notes (updated 5/4/2023)

This appears to be referring to the file src/applications/facility-locator/components/search-results-items/common/LocationPhoneLink.jsx.

  // The Telephone component will throw an error if passed an invalid phone number.
  // Since we can't use try/catch or componentDidCatch here, we'll just do this:
  if (contact.length !== 10) {
    return null;
  }

We should confirm that this validation is no longer needed. If the component handles this correctly, we should just be able to delete the entire block of code shown above.


Tasks

  • Remove phone number digit validation

Acceptance Criteria

  • Code no longer contains validation check for 10 digit phone numbers

@mmiddaugh mmiddaugh added the vsa label Apr 27, 2021
@mpelzsherman mpelzsherman changed the title [CONSIDER] remove phone validation check remove phone validation check Aug 9, 2021
@jilladams jilladams transferred this issue from department-of-veterans-affairs/va.gov-team Apr 18, 2023
@jilladams jilladams added Facilities Facilities products (VAMC, Vet Center, etc) Technical debt VAMC CMS managed product owned by Facilities team VA.gov frontend CMS team practice area and removed vsa vamc-pages labels Apr 18, 2023
@davidmpickett
Copy link
Contributor

Phone Number validation has changed a lot since 2021. See #17854 for current state

@davidmpickett davidmpickett closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) sitewide Technical debt VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

3 participants