Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading structure in Service Accordions is not helpful to user #18222

Open
4 tasks
laflannery opened this issue May 24, 2024 · 8 comments
Open
4 tasks

Heading structure in Service Accordions is not helpful to user #18222

laflannery opened this issue May 24, 2024 · 8 comments
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility services (multi-product) A label for issues that affect how services are handled across multiple facility products Needs refining Issue status Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@laflannery
Copy link
Contributor

laflannery commented May 24, 2024

Description

This is somewhat related to the ticket regarding "Appointments" showing with no content but ultimately because we have so many headings, and it's all connected to other templates, they aren't hierarchical like they should be.

For example, the phone number under appointments should be an h6 but there is really no reason to be going that far down, which is why I'm advocating to just get rid of these headers here - they aren't necessary.

The bigger issue is that having the heading level the same is potentially going to create more confusion because it's muddying the relationship of these elements

Acceptance Criteria

  • Determine if it is possible/feasible/desirable to update headings without touching VAMCs
  • If so, determine how to update the headings for the best UX and a11y experience
  • Requires design review
  • Requires accessibility review
@laflannery laflannery added the Needs refining Issue status label May 24, 2024
@davidmpickett
Copy link
Contributor

davidmpickett commented May 31, 2024

This might need to be split into a few tickets to cover the various places where we are using headings that we want to move toward bold/strong text instead.

- VBA main page template
- Should be pretty small scope and could be launch blocking
- I think Location and Contact information is the main area to fix
- Address, phone numbers, and office hours

  • VBA & VAMC service accordions
    • I think we should fix these on VAMCs and VBA at the same time since they share partial templates

- Other places on VAMCs
- Etc.

@davidmpickett davidmpickett added Regional office CMS managed VBA product owned by the Facilities team Facility services (multi-product) A label for issues that affect how services are handled across multiple facility products VAMC CMS managed product owned by Facilities team Facilities Facilities products (VAMC, Vet Center, etc) labels May 31, 2024
@jilladams jilladams added the VA.gov frontend CMS team practice area label May 31, 2024
@Agile6MSkinner
Copy link

Agile6MSkinner commented Jun 3, 2024

To Dave's comment, let's split out another ticket for the Man Page Template, which will will consider launch blocking. This ticket will stay in the backlog for fast follow/national rollout. I will work with @laflannery and/or @davidmpickett to create the ticket.

@laflannery
Copy link
Contributor Author

laflannery commented Jun 4, 2024

To be clear, this ticket is referring to the heading structure within the accordions, as described in the description above. The headings outside the accordions, while eventually they could probably be improved, they aren't hindering the user's ability to understand the content.

@Agile6MSkinner
Copy link

After talking with @laflannery we are moving this to the national rollout epic because it is related to a more global issue and will require a lot of design discovery. It's not a high-priority issue, it just looks bad.

@thejordanwood Do you have an epic that this could be included in or a design discovery ticket that we could set as a pre-req?

@davidmpickett
Copy link
Contributor

@thejordanwood Do you have an epic that this could be included in or a design discovery ticket that we could set as a pre-req?

@davidmpickett davidmpickett changed the title VBA QA: Heading structure is not helpful to user Heading structure in Service Accordions is not helpful to user Jun 4, 2024
@davidmpickett
Copy link
Contributor

To be clear, this ticket is referring to the heading structure within the accordions, as described in the description above. The headings outside the accordions, while eventually they could probably be improved, they aren't hindering the user's ability to understand the content.

Updated ticket title to reflect this scope

@Agile6MSkinner
Copy link

@davidmpickett @thejordanwood Do we think that the work described here is discrete or will it be taken care of in other issues/tickets/epics?

@davidmpickett
Copy link
Contributor

@davidmpickett @thejordanwood Do we think that the work described here is discrete or will it be taken care of in other issues/tickets/epics?

To my knowledge this is the only place this work is documented in a ticket. This could potentially be a fix to make during AP template migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility services (multi-product) A label for issues that affect how services are handled across multiple facility products Needs refining Issue status Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

4 participants