Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facility Locator: Move mileage in search results items #18434

Closed
3 tasks done
laflannery opened this issue Jul 2, 2024 · 4 comments
Closed
3 tasks done

Facility Locator: Move mileage in search results items #18434

laflannery opened this issue Jul 2, 2024 · 4 comments
Assignees
Labels
accessibility Issues related to accessibility Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team sitewide VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

laflannery commented Jul 2, 2024

Background

In an effort to move the facility locator redesign work forward, we are trying to break up the large project into smaller, more manageable pieces that can be completed more easily and added into sprints.

Description

Move milage down below the header/facility name for the search results items in the Facility Locator

  • Currently on the Facility Locator results, the milage is the first element in each item in the results, before the heading of the item. If a screen reader user navigates by headings, they are going to miss this information because they wouldn't expect to navigate backwards.
  • By moving the milage down, after the heading, it will be less likely that users will miss this information.
  • Link to Figma
Screenshots

Current display
image

New display
image

Acceptance Criteria

  • For each results listing on the Facility locator, the milage is below the heading/facility name - as shown in the Figma file
  • Requires design review
  • Requires accessibility review

Accessibility review steps

Confirm the milage resizes appropriately with the browser font settings

  1. Go to the Facility Locator page /find-locations
  2. Complete a search, so that the results list appears
  3. Within your default browser, update your settings to the largest font size available (you do not need to test all of these):
    • Chrome: Settings > Appearance > Font size
    • Firefox: Settings > Language & Appearance > Fonts
    • Edge: Settings > Appearance > Fonts
  4. Confirm that the milage increases in size correctly

Confirm the milage is read properly and in the correct order by VoiceOver
(because I believe the majority of people on the team have Macs)

  1. Go to the Facility Locator page /find-locations
  2. Complete a search, so that the results list appears
  3. Turn on VO: CMD + FN + F5
  4. Using the rotor menu, jump to one of the Facility name headings
    • CTRL + OPT + U
    • Arrow right until you get to the Headings menu
    • Arrow down to go through the available headings
    • Enter when you are on the heading you want to jump to
  5. Read from that point on and confirm you hear the milage read AFTER the heading now
    • CTRL + OPT + A
@laflannery laflannery added Needs refining Issue status VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team accessibility Issues related to accessibility sitewide labels Jul 2, 2024
@laflannery laflannery assigned laflannery and unassigned laflannery Jul 2, 2024
@mmiddaugh
Copy link
Contributor

@mmiddaugh
Copy link
Contributor

@laflannery should we separate the mileage position change from the TTY number to make this easier to pull in as a quick win?

@laflannery laflannery changed the title Facility Locator: Move milage and add TTY number to search results items Facility Locator: Move milage in search results items Jul 9, 2024
@laflannery
Copy link
Contributor Author

@mmiddaugh Updated, TTY ticket is now here

@mmiddaugh mmiddaugh changed the title Facility Locator: Move milage in search results items Facility Locator: Move mileage in search results items Jul 24, 2024
@FranECross FranECross removed the Needs refining Issue status label Sep 11, 2024
@randimays randimays self-assigned this Sep 20, 2024
@randimays
Copy link
Contributor

Validated successfully in production; closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

5 participants