Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Add "Mission Explainer" / "Our commitment" Box to VetCenter Facility Pages #18724

Closed
3 of 9 tasks
Agile6MSkinner opened this issue Jul 23, 2024 · 15 comments
Closed
3 of 9 tasks
Assignees
Labels
current sprint Facilities Facilities products (VAMC, Vet Center, etc) points-3 sitewide VA.gov frontend CMS team practice area Vet Center CMS managed product owned by Facilities team

Comments

@Agile6MSkinner
Copy link

Agile6MSkinner commented Jul 23, 2024

DO NOT MERGE until @Agile6MSkinner is notified for change management purposes

FINAL CONTENT FROM CAIA: department-of-veterans-affairs/va.gov-team#83961 Drupal functionality was created using Draft content. We do not want to publish that to the FE. Could build this and hold merge until final content is received, or opt not to work it yet.

User Story

As a veteran, beneficiary or caretaker, I would like to have a summary box displayed at the top of VetCenter facility pages so that I am quickly able to understand the mission and services offered for the facility I am looking at.

Description

Implement a GraphQL query to fetch VetCenter mission explainer content and use the existing "Summary Box" component from the design system to display it on the Vet Center pages.

Figma Designs
GraphQL recommendations from Eli

ACs:

  1. Blue Summary Box exists at the top all VetCenter facility pages
  2. Includes content from Mission Explainer content block created in Drupal: Add "Mission Explainer" Content Block to VetCenter Centralized Content #18723
  3. The blue summary box must use the existing "Summary Box" design component and follow all applicable annotations indicated here in Figma.

Tasks

Preview Give feedback

QA

Preview Give feedback
@Agile6MSkinner Agile6MSkinner added Facilities Facilities products (VAMC, Vet Center, etc) sitewide Vet Center CMS managed product owned by Facilities team VA.gov frontend CMS team practice area Blocked Issues that are blocked on factors other than blocking issues. labels Jul 23, 2024
@davidmpickett
Copy link
Contributor

Noting that we have a request out to the Design System team to update their guidance on On This Page component so we could exclude the blue box from having a jump link

@Agile6MSkinner Agile6MSkinner removed the Blocked Issues that are blocked on factors other than blocking issues. label Aug 5, 2024
@aklausmeier
Copy link

Noting that we do not have final content from CAIA.

@jilladams jilladams added the Blocked Issues that are blocked on factors other than blocking issues. label Aug 16, 2024
@jilladams
Copy link
Contributor

Added details on the CAIA blocker in ticket body. I bumped department-of-veterans-affairs/va.gov-team#83961 as well to see if they have updates, since we haven't heard anything this week.

We are also blocked on product decision around timing / priority for building out Vet Centers 2.0 in content-build (and creating more drift for the AP template to catch up) vs. waiting for AP to ship, and building it all out in AP instead.

FYI @mmiddaugh @Agile6MSkinner

@jilladams
Copy link
Contributor

I think we could do a quick estimate in refinement re: pulling fields through to FE in content-build, just to understand the lift, if we have time.

@jilladams jilladams changed the title Add "Mission Explainer" Box to VetCenter Facility Pages FE: Add "Mission Explainer" Box to VetCenter Facility Pages Aug 16, 2024
@Agile6MSkinner
Copy link
Author

@aklausmeier @laflannery Let's look at the DST ticket for exclude the explainer box from "One This Page"

@Agile6MSkinner
Copy link
Author

@eselkin Will do a bit of exploration on Graph QL and add to ticket.

@aklausmeier
Copy link

@Agile6MSkinner I have pinged the DST team for an update on an ETA for a fix to allowing exclusion of H2's from the On this page/ToC component

@eselkin
Copy link
Contributor

eselkin commented Sep 25, 2024

A simple GraphQL query for vet centers is:

query GetVetCenters {
  nodeQuery(
    limit: 1
    offset: 100
    filter: {conditions: [{field: "status", value: ["1"], enabled: true}, {field: "type", value: ["vet_center"]}]}
  ) {
    entities {
      ... on NodeVetCenter {
        entityId
        title
        fieldMissionExplainer {
          fetched
        }
      }
    }
  }
}

Returns something that looks like:

{
  "data": {
    "nodeQuery": {
      "entities": [
        {
          "entityId": "3711",
          "title": "Pasco County Vet Center",
          "fieldMissionExplainer": {
            "fetched": {
              "fieldMagicheadBody": [
                {
                  "value": "<ul><li>Our team will work with you to identify your goals and make a plan to meet them. We'll help you and your family build meaningful connections to improve your quality of life.</li><li>Our counseling is confidential. We won’t share any information about you or the services you receive without your permission—except in a life-threatening situation. And our records can't be accessed by other VA offices, the Defense Department, military units, or community providers.</li><li>We encourage you to contact us, even if you're not sure you're eligible. We'll find a way to connect you with the help you need—at VA and your community.</li></ul>",
                  "format": "rich_text_limited",
                  "processed": "<ul>\n<li>Our team will work with you to identify your goals and make a plan to meet them. We'll help you and your family build meaningful connections to improve your quality of life.</li>\n<li>Our counseling is confidential. We won’t share any information about you or the services you receive without your permission—except in a life-threatening situation. And our records can't be accessed by other VA offices, the Defense Department, military units, or community providers.</li>\n<li>We encourage you to contact us, even if you're not sure you're eligible. We'll find a way to connect you with the help you need—at VA and your community.</li>\n</ul>\n"
                }
              ],
              "fieldMagicheadHeading": [
                {
                  "value": "Our commitment"
                }
              ]
            }
          }
        }
      ]
    }
  }
}

The fieldMissionExplainer is a magic head array with one element (it's been limited to 1)... Not all Vet Centers (unpublished? or something else, not sure) have the fieldMissionExplainer

If the Vet Center does not have fieldMissionExplainer, the whole object is null

for example this query:

query GetVetCenters {
  nodeQuery(
    limit: 1
    offset: 1
    filter: {conditions: [{field: "status", value: ["1"], enabled: true}, {field: "type", value: ["vet_center"]}]}
  ) {
    entities {
      ... on NodeVetCenter {
        entityId
        title
        fieldMissionExplainer {
          fetched
        }
      }
    }
  }
}

returns

{
  "data": {
    "nodeQuery": {
      "entities": [
        {
          "entityId": "3665",
          "title": "Alexandria, VA Vet Center",
          "fieldMissionExplainer": null
        }
      ]
    }
  }
}

@laflannery
Copy link
Contributor

@Agile6MSkinner There should be an AC/Task, (I'am not clear on the distinction tbh) to indicate that the summary box should follow all applicable annotations indicated here in Figma. Are you able to add that to the correct list above?

@aklausmeier
Copy link

@Agile6MSkinner The DST is expecting to allow the exclusion of H2s by December so we will need to pull that AC into it's own ticket as a follow-up when that is revised in the design system component.

@davidmpickett
Copy link
Contributor

Not all Vet Centers (unpublished? or something else, not sure) have the fieldMissionExplainer

@omahane - Could this be related to the default value thing for Entity Fetch Fields?

@jilladams jilladams changed the title FE: Add "Mission Explainer" Box to VetCenter Facility Pages FE: Add "Mission Explainer" / "Our services" Box to VetCenter Facility Pages Oct 2, 2024
@jilladams jilladams removed the Blocked Issues that are blocked on factors other than blocking issues. label Oct 2, 2024
@jilladams jilladams changed the title FE: Add "Mission Explainer" / "Our services" Box to VetCenter Facility Pages FE: Add "Mission Explainer" / "Our commitment" Box to VetCenter Facility Pages Oct 2, 2024
@eselkin
Copy link
Contributor

eselkin commented Oct 7, 2024

@davidmpickett Not sure, but if you go to the node's page on my tugboat or prod the mission explainer is in fact missing:
https://main-gypmlk8q1dooxvfrxv2hfyasml9oalln.demo.cms.va.gov/alexandria-va-vet-center
https://prod.cms.va.gov/alexandria-va-vet-center

@jilladams
Copy link
Contributor

@Agile6MSkinner could you add latest status here? OK for Eli to merge?

@Agile6MSkinner
Copy link
Author

Apologies, I thought I put the go-ahead here too. We can merge this @eselkin

@jilladams
Copy link
Contributor

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current sprint Facilities Facilities products (VAMC, Vet Center, etc) points-3 sitewide VA.gov frontend CMS team practice area Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

6 participants