News release page shows Media contact info for Staff that has been archived

[laflannery]

[2024-11-13] Needs refining in order to know whether it's a FE / Drupal fix

Description

While testing something else I noticed that on this News release page, Kenneth Griffin had been added as the media contact. However, in Drupal Kenneth as been archived as he's no longer an employee. His node is here and you can see the status and the revision log message

My question is - since his info is archived, should the FE be showing his info anymore? This seems incorrect? And possible related to the similar issues we have been working on recently where draft content has been showing in various places?

Additional information

Engineering notes / background

Analytics considerations

Testing & QA

Scope / Impact analysis

What, if anything, could break as a result of this change?
Engineer should assess this when approaching PR.

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

• Functional testing:
• Code review:
• Design review:
• Accessibility review:
• Product acceptance:

Acceptance criteria

ACs should capture expected behavior, to inform test plans. Consider devices, documentation updates including KBs, change management, and content model when applicable.

• The VA.gov current Public Affairs media contact should display as the media contact
• Changes are added to next-build build of news releases also.
• Impact analysis is filled out and QA test plan is updated accordingly
• Does this product have an existing regression test plan?
  • Yes, link:
  • No, regression test plan will be created as part of the work / points in this ticket

[davidmpickett]

Two possible ways to address

Drupal - on archive, remove all existing entity references

• We have the Entity Reference Unpublished module active. Is there a way to have that only allow referencing Drafts, rather than Archived?

FE - only show published staff profiles on News Releases

• Update query to get moderation state
• Update template to respect moderation state

[jilladams]

@FranECross fysa: there is a next-build template build for news releases:

• Next Build Template: News Release #19576
• Next Build Template: News Release Listing #19577

Anything we do to modify them near-term needs to happen in next-build as well. I added that as an AC.

[FranECross]

We want to keep this in the backlog for now.
Questions:

• what displays if no name is there?
• is there a list of current media contacts?

Michelle to contact miami editor to discuss this.

[EWashb]

@mmiddaugh and I will bring up with VHA DM

[mmiddaugh]

option: rather than connecting a press release to a specific individual's staff profile, we may need a method for adding/defaulting to a general contact which is consistent and can't be archived, such as the media office and phone number