VAMC Facility should require a VAMC System menu parent link

[jilladams]

Description

In the Drupal CMS, it's possible to publish a VAMC Facility with the default root menu parent link. This results in a VAMC Facility that will not be housed under a VAMC System parent. That facility will have no IA / breadcrumb, within the correct VAMC content structure.

We found this via an incident where a VAMC Facility in "Coming Soon" status was accidentally published while the Editor was updating the Operating Status. (Slack thread) That publish broke content-release, due to the missing breadcrumb. CMS team is shipping a change that will not break the build, and will log but not error: department-of-veterans-affairs/content-build#2417

Currently we mitigate this manually via the help desk, where a new facility that is flagged should trigger a Helpdesk process where they engage the editor, set the correct Menu parent (and Section, etc).

However: it is possible to accidentally publish, without those settings in place. We should prevent it.

Acceptance criteria

• VAMC Facilities require a VAMC System menu parent in order to publish

[jilladams]

This could be a client-side validation issue? The System field is already required: https://prod.cms.va.gov/node/add/health_care_local_facility

[omahane]

I believe the issue was the Parent link, rather than the Section. The Parent Link will default to the menu root, so the field is not empty. It is just not set in a way that content-build expects (or should expect).

I think that we can make a constraint validator that checks to see if the new state will be published and looks to see if the Parent link is the menu root. If so, it can trigger.