Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Union type #39

Open
skaldesh opened this issue Apr 28, 2020 · 2 comments
Open

Union type #39

skaldesh opened this issue Apr 28, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone
v1.6.1

Comments

@skaldesh
Copy link
Member

An idea @r0l1 had today was to extend orbit so that it supports type switches. Say you have the structs IntValue, FloatValue, etc.., but want to make one API call that says getValue(id string) AnyValue.
The AnyValue in the example could be expressed as a union type union(IntValue, FloatValue) and would have to be specially encoded/decoded by orbit under the hood
@skaldesh skaldesh added the enhancement New feature or request label Apr 28, 2020
@skaldesh skaldesh added this to the v1.5.0 milestone May 6, 2020
@skaldesh skaldesh modified the milestones: v1.5.0, v1.5.1 Oct 15, 2020
@skaldesh skaldesh modified the milestones: v1.5.1, v1.6.1 Jan 26, 2021
@skaldesh
Copy link
Member Author

@r0l1 whats the status on this? Still needed?

@r0l1
Copy link
Member

r0l1 commented Mar 22, 2021

Let's leave this open, but postpone this idea. Adds a lot of complexity and currently it is not worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.6.1
Development

No branches or pull requests
2 participants
@r0l1 @skaldesh