-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hellfire] OperateL2Door - Please check bin exactness #2053
Comments
It's known that it's not bin exact for hellfire: #1397 |
That's why I decompiled it. It looks a little different in the picture above. |
If you like we can help you setup the tools so that you can check and make a pull request that makes it bin exact |
Yes. Thank you. That would be helpful. I'll be asking some questions about the tools soon if that's okay. |
Definitely. Though it would be easiest via chat, there is even a channel there with a guide for how to get things running for working on Hellfire. |
Happy to see you join us in the reversing efforts @Chance4us :) |
Thank you also for the effort of all of you guys. |
Thank you @qndel |
void OperateL2Door(int pnum, int i, DIABOOL sendflag)
{
int dpx, dpy;
dpx = abs(object[i]._ox - plr[pnum]._px);
dpy = abs(object[i]._oy - plr[pnum]._py);
if (dpx == 1 && dpy <= 1 && object[i]._otype == OBJ_L2LDOOR)
OperateL2LDoor(pnum, i, sendflag);
if (dpx <= 1 && dpy == 1 && object[i]._otype == OBJ_L2RDOOR)
OperateL2RDoor(pnum, i, sendflag);
} bin exact in this form |
When the code was decompiled, the comparison was not the same.
Please check the assembler code.
The text was updated successfully, but these errors were encountered: